Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding extensions to GraphQLParams #250

Closed
williambailey opened this issue Jul 6, 2022 · 0 comments · Fixed by #243
Closed

Adding extensions to GraphQLParams #250

williambailey opened this issue Jul 6, 2022 · 0 comments · Fixed by #243

Comments

@williambailey
Copy link

It would be handy if GraphQLParams included the extensions?: { [name: string]: any }; parameter to allow quick and easy access to incoming request extensions when using getGraphQLParameters.

https://github.com/graphql/graphql-over-http/blob/main/spec/GraphQLOverHTTP.md#request-parameters

  • {extensions} - (Optional): This entry is reserved for implementors to extend the protocol however they see fit.
This was referenced Jul 8, 2022
Open
Merged
williambailey added a commit to williambailey/graphql-helix that referenced this issue Jul 11, 2022
@williambailey
Fix getGraphQLParameters extensions for POST
3a76725 
Thanks for looking at contra#250 quickly. Just spotted a small issue. The current code is missing the final `s` in `extensions` for `POST` requests.
@williambailey williambailey mentioned this issue Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: include operationName and extensions in executionContext contra/graphql-helix
1 participant
@williambailey