Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user code to throw HttpError during context building #43

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Allow user code to throw HttpError during context building #43

merged 1 commit into from
Sep 7, 2021

Conversation

mosch
Copy link
Contributor

@mosch mosch commented Jul 25, 2021

This allows me to throw an HttpError with a 401 status code within the contextFactory.

@PabloSzx PabloSzx mentioned this pull request Aug 17, 2021
Closed
@dotansimha dotansimha changed the base branch from master to better-error-handling September 7, 2021 16:21
@dotansimha
Copy link
Collaborator

Thanks @mosch !
I'm doing some work to improve error handling in Helix. Merging to a temporary PR and then we can merge it when all error-handling fixes are done :)

@dotansimha dotansimha changed the title allow client side code to throw HttpError Allow user code to throw HttpError during context building Sep 7, 2021
@dotansimha dotansimha merged commit 039e97e into contra:better-error-handling Sep 7, 2021
@dotansimha dotansimha mentioned this pull request Sep 7, 2021
Merged
@mosch
Copy link
Contributor Author

mosch commented Sep 7, 2021

I appreciate. Thanks for your work!

dotansimha pushed a commit that referenced this pull request Sep 13, 2021
@mosch @dotansimha
Allow user code to throw HttpError during context building (#43)
ac1e662
@github-actions github-actions bot mentioned this pull request Sep 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotansimha dotansimha dotansimha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mosch @dotansimha