#356 - Document how to use npm to build the theme within DDEV #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in DDEV contrib-tracker#356 - Document how to use npm to build the theme within DDEV
|
@hussainweb |
hussainweb
reviewed
May 6, 2024
There was a problem hiding this comment.
@rishabjasrotia, I am only getting back to addressing PRs here. I really like this change and I want npm to be executed by DDEV, but please see my comment.
| ## Description: Run npm commands inside theme. | ||
| ## Usage: npm [flags] [args] | ||
| ## Example: "npm install or npm rebuild node-sass or npm run build or npm run watch" | ||
| cd /var/www/html/web/themes/custom/contribtracker && npm $@ |
There was a problem hiding this comment.
Thanks for this. I am not sure about this because I recently found out that DDEV handles this by translating the host path into a guest path when running ddev commands. This means that if we switch to the theme directory and run ddev npm, it would work fine. I am wondering if that is more intuitive than this approach. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#356 - Document how to use npm to build the theme within DDEV