Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct REDIS RESP NIL response #73

Closed
jonhoo opened this issue Nov 6, 2017 · 0 comments
Closed

Use correct REDIS RESP NIL response #73

jonhoo opened this issue Nov 6, 2017 · 0 comments

Comments

@jonhoo
Copy link
Collaborator

jonhoo commented Nov 6, 2017

When a FETCH returns no results, it currently responds with:

$0\r\n
\r\n

However, REDIS RESP defines the Null Bulk String specifically "to signal non-existence of a value":

$-1\r\n

Which seems more appropriate.
@mperham mperham closed this as completed in 55b000e Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonhoo