WIP: Kickoff #1
Merged
WIP: Kickoff #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3l1x
requested changes
Dec 17, 2017
composer.json
Outdated
| @@ -0,0 +1,44 @@ | |||
| { | |||
| "name": "apitte/console", | |||
| "minimum-stability": "dev", | |||
There was a problem hiding this comment.
Please reformat composer.json according to the others. (https://github.com/apitte/openapi/blob/master/composer.json)
composer.json
Outdated
| "prefer-stable": true, | ||
| "require": { | ||
| "php": ">= 5.6", | ||
| "apitte/core": "^0.1.0@dev", |
src/Command/RouteDumpCommand.php
Outdated
| use Symfony\Component\Console\Style\SymfonyStyle; | ||
|
|
||
| /** | ||
| * Class RouteDumpCommand |
There was a problem hiding this comment.
Remove this phpdoc - it's useles, the name is already in filename.
src/Command/RouteDumpCommand.php
Outdated
| const TABLE_HEADER = ['Method', 'Path', 'Handler', 'Parameters']; | ||
|
|
||
| /** | ||
| * @var \Apitte\Core\Schema\Schema |
There was a problem hiding this comment.
Please use single link phpdoc and import namespace for Schema;
| /** | ||
| * @return void | ||
| */ | ||
| protected function configure() |
There was a problem hiding this comment.
The first method should be construct.
src/Command/RouteDumpCommand.php
Outdated
| } | ||
|
|
||
| /** | ||
| * RouteDumpCommand constructor. |
There was a problem hiding this comment.
Remove this phpdoc except the $schema.
src/Command/RouteDumpCommand.php
Outdated
| * @param \Symfony\Component\Console\Output\OutputInterface $output | ||
| * @return void | ||
| */ | ||
| public function printEndpointsTable(OutputInterface $output) |
There was a problem hiding this comment.
Move this to execute method please.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR is just kickoff for making this package ready. Can we start working on this? I just need to know what needs to be done and I will update this PR.
Thanks