Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve routing - routes order #69

Closed
mabar opened this issue Jan 24, 2019 · 1 comment · Fixed by #115
Closed

Improve routing - routes order #69

mabar opened this issue Jan 24, 2019 · 1 comment · Fixed by #115
Assignees

Comments

@mabar
Copy link
Contributor

mabar commented Jan 24, 2019

If routes /foo/bar and /foo/{var} are defined then route /foo/bar should always match for /foo/bar url, no matter in which order are controllers registered. We should also check for collisions.

See also swagger docs

@mabar mabar self-assigned this Jan 24, 2019
@mabar
Copy link
Contributor Author

mabar commented Jun 4, 2019

Also /foo and /foo/{bar}/baz should work.
Order should be corrected during Schema building, solving that in SimpleRouter would cause performance decrease.

It would be also nice to replace this with endpoints grouping to reduce schema lookups

@mabar mabar mentioned this issue Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant