FileDebugMode #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3l1x
reviewed
May 22, 2018
src/ExtraConfigurator.php
Outdated
| @@ -15,9 +14,6 @@ class ExtraConfigurator extends Configurator | |||
| public function __construct() | |||
| export NETTE__DATABASE__HOST=localhost | ||
| ```php | ||
| $configurator = new ExtraConfigurator(); | ||
| $configurator->setEnvDebugMode(); | ||
| ``` | ||
|
|
| */ | ||
| public static function setup(Configurator $configurator) | ||
| public function setFileDebugMode($fileName = NULL) | ||
| { |
There was a problem hiding this comment.
It's nice. What about little tunning?
function setFileDebugMode($fileName = null)
{
$appDir = $this->parameters['appDir'] ? $this->parameters['appDir'] : null;
// No filename and no application root dir
if (!$fileName && !$appDir) return;
$content = @file_get_contents($fileName ?: $appDir . '/../.debug');
// Not exists or not readable
if ($content === false) return;
if (empty($content)) {
$this->setDebugMode(true);
} else {
$debug = self::parseDebugValue(trim($content));
$this->setDebugMode($debug);
}
}
There was a problem hiding this comment.
@f3l1x seems fine besides empty($content) cant be used cause its invalid for "0" etc
There was a problem hiding this comment.
I see, $content === '' would be fine.
vody105
force-pushed
the
feature/file-debug-mode
branch
from
d497a5c
to
1e397fa
Compare
|
Najs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.