Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading resources over insecure protocol #32

Closed
Majkl578 opened this issue Jan 27, 2016 · 5 comments
Closed

Loading resources over insecure protocol #32

Majkl578 opened this issue Jan 27, 2016 · 5 comments

Comments

@Majkl578
Copy link

Take this addon for example (applies to any addon): https://componette.com/uestla/twigrid/

You are loading external images over insecure HTTP protocol.

Načítání smíšeného (nezabezpečeného) zobrazovaného obsahu na zabezpečené stránce "http://isitmaintained.com/badge/resolution/uestla/twigrid.svg"[Zjistit více] twigrid
Načítání smíšeného (nezabezpečeného) zobrazovaného obsahu na zabezpečené stránce "http://isitmaintained.com/badge/open/uestla/twigrid.svg"[Zjistit více] twigrid
Načítání smíšeného (nezabezpečeného) zobrazovaného obsahu na zabezpečené stránce "http://i.imgur.com/RHzFX1V.png"[Zjistit více] twigrid
@chemix
Copy link
Member

chemix commented Jan 27, 2016

Nette Forum this issue resolves with cache for all images on own domain.

solution

parse texy/markdown description, find all images, download all images to local storage, update paths in texty, convert to html and cache it.

if file is not exists, replace path to default image (something like small [wrong image])

when downloading images to local path check if is sure only images

all these: *.jpg, *.png, *.jpeg, *.gif, *.svg

@f3l1x
Copy link
Member

f3l1x commented Jan 27, 2016

  1. I change isitmaintained badges to HTTPS

  2. I dont think we need it right now. I put it to roadmap, but at this time I plan other things.

@f3l1x f3l1x added the feature label Jan 27, 2016
@chemix
Copy link
Member

chemix commented Jan 27, 2016

👍

@chemix
Copy link
Member

chemix commented Jan 27, 2016

PR is welcome @Majkl578 ;-)

f3l1x added a commit that referenced this issue Jan 28, 2016
@f3l1x
Copy link
Member

f3l1x commented Feb 12, 2016

Content fixed via loading readme in HTML format from Github.

@f3l1x f3l1x closed this as completed Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants