Fixing missing quotes in CSS attribute selectors #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zipper Good for me. Please, rebase. |
… has a value eg. with `.`, the jQuery sizzle engine throws an error when there are no qutes around the value.
zipper
force-pushed
the
fix-missing-quotes
branch
from
0d5edc6
to
35adf2c
Compare
|
@radimvaculik Rebased 👍 |
radimvaculik
approved these changes
Feb 7, 2023
|
@radimvaculik Pls for info - did you test it? |
|
@paveljanda No, but it's obvious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing missing quotes in CSS attribute selectors. When data attribute has a value eg. with
., the jQuery sizzle engine throws an error when there are no quotes around the value. This PR fixes that by adding"around the attribute value.