Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem with filters #40

Merged
merged 1 commit into from
Feb 1, 2016
Merged

Fixed problem with filters #40

merged 1 commit into from
Feb 1, 2016

Conversation

juniwalk
Copy link
Contributor

@juniwalk juniwalk commented Feb 1, 2016

Trying to assign value from persistent holder to uninitialized filter.

Trying to assign value from persistent holder to uninitialized filter.
paveljanda added a commit that referenced this pull request Feb 1, 2016
@paveljanda paveljanda merged commit 5c6cc37 into contributte:master Feb 1, 2016
@paveljanda
Copy link
Member

Thanks.

@juniwalk juniwalk deleted the fix-filter-bug branch February 1, 2016 10:10
@juniwalk
Copy link
Contributor Author

juniwalk commented Feb 1, 2016

Looks like this bug was there because I switched o5/grido to your datagrid and grido probably uses same scheme for "filters". Explains why I saw the problem immediately after installing the datagrid.

@paveljanda
Copy link
Member

Yes. This error occurred also when you did some filtering and then removed a used filter from grid.

@juniwalk
Copy link
Contributor Author

juniwalk commented Feb 1, 2016

Oh I see, did I fix it properly then?

@paveljanda
Copy link
Member

Almost yes. :)

There still remains the value in session, I didn't notice that before - thanks again. I don't know if it is a good idea to unset it.

... Yes, it should not be there. You may create a new filter with different values to select. Then the session value won't be in current select range.

I will implement that immediately and release version 1.0.4.

@juniwalk
Copy link
Contributor Author

juniwalk commented Feb 1, 2016

Alright :) I am having another issue with tree rendering, I will debug it and report to you back later.

@JakubKontra
Copy link
Contributor

Is that bug about nodes moving?

@juniwalk
Copy link
Contributor Author

juniwalk commented Feb 1, 2016

@JakubKontra It tries to read has_children value from my entity as if it was array, which of course fails horribly.

@paveljanda
Copy link
Member

That should not happen. The only place, where it is reading that property is the tree view template on line 16 and there is a check whether given item is an object or an array:

{var $has_children = is_object($item) ? $item->{$tree_view_has_children_column} : $item[$tree_view_has_children_column]}

@juniwalk
Copy link
Contributor Author

juniwalk commented Feb 1, 2016

I am aware of that, I saw it in tracy report, strange thing is, I just tried it again and it works. :D
//EDIT: Nope I just broke something else, it still gives the same error Undefined index: hasChildren.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants