-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed problem with filters #40
Conversation
Trying to assign value from persistent holder to uninitialized filter.
Thanks. |
Looks like this bug was there because I switched o5/grido to your datagrid and grido probably uses same scheme for "filters". Explains why I saw the problem immediately after installing the datagrid. |
Yes. This error occurred also when you did some filtering and then removed a used filter from grid. |
Oh I see, did I fix it properly then? |
Almost yes. :) There still remains the value in session, I didn't notice that before - thanks again. I don't know if it is a good idea to unset it. ... Yes, it should not be there. You may create a new filter with different values to select. Then the session value won't be in current select range. I will implement that immediately and release version 1.0.4. |
Alright :) I am having another issue with tree rendering, I will debug it and report to you back later. |
Is that bug about nodes moving? |
@JakubKontra It tries to read |
That should not happen. The only place, where it is reading that property is the tree view template on line 16 and there is a check whether given item is an object or an array: {var $has_children = is_object($item) ? $item->{$tree_view_has_children_column} : $item[$tree_view_has_children_column]} |
I am aware of that, I saw it in tracy report, strange thing is, I just tried it again and it works. :D |
Trying to assign value from persistent holder to uninitialized filter.