Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setOpenInNewTab fluent #425

Merged
merged 1 commit into from Dec 7, 2016

Conversation

2 participants
@dakorpar
Copy link
Member

dakorpar commented Dec 7, 2016

just bumped into this one and feels anoying that in code setOpenInNewTab does not return $this
I also added default to be true, I believe that's how is used through grid ussually...

@dakorpar dakorpar changed the title Make set open in new tab fluent Make setOpenInNewTab fluent Dec 7, 2016

@juniwalk juniwalk merged commit cde2907 into contributte:master Dec 7, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Dec 7, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.