Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed filter escaping for dibi 2.x. #479

Merged
merged 2 commits into from Mar 1, 2017

Conversation

2 participants
@radekdostal
Copy link
Contributor

radekdostal commented Mar 1, 2017

Class Dibi\Helpers doesn't exists in dibi 2.x.
Related to #477.

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Mar 1, 2017

@radekdostal Please save the driver to $driver variable outside the foreach so it is not called each loop.

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Mar 1, 2017

@radekdostal Please, include that call on line 188. Thanks :)

@juniwalk juniwalk merged commit 05d1e10 into contributte:v5.x Mar 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Mar 1, 2017

Great, thanks!

@radekdostal radekdostal deleted the radekdostal:fix-escape-dibi-2.x branch Mar 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.