Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add naja 2.0 support #927

Merged
merged 8 commits into from Nov 17, 2020
Merged

Add naja 2.0 support #927

merged 8 commits into from Nov 17, 2020

Conversation

rozsival
Copy link
Member

@rozsival rozsival commented Nov 4, 2020

This PR adds naja:2.0 support to datagrid assets while maintaining full backwards compatibility with naja:1.x versions.

Followed Upgrading from 1.x guide.

Changes:

  • added naja version check
  • added najaEventParams helper to extract naja event properties
  • added najaRequest helper to extract request or xhr from naja event based on version
  • updated NewExtension classes to work with both 1.x || 2.x versions

@rozsival rozsival mentioned this pull request Nov 4, 2020
Closed
@rozsival
Copy link
Member Author

rozsival commented Nov 5, 2020 •
edited

CI failing since 57a8464, no changes made in this PR broke it. Let me know after CI fix is issued, I will merge it back to this PR.

@rozsival
Merge remote-tracking branch 'upstream/master' into master
8daacc5 
* upstream/master:
  Tests: rename, fix notice
  Added elastic datasource
@rozsival
Copy link
Member Author

@paveljanda Could this be merged?

@paveljanda
Copy link
Member

Cool, thanks!

@paveljanda paveljanda merged commit a879f2c into contributte:master Nov 17, 2020
@f3l1x f3l1x mentioned this pull request Dec 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rozsival @paveljanda