WIP: v2 with money object, strict types, type hints #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3l1x
requested changes
Dec 23, 2020
f3l1x
reviewed
Dec 23, 2020
|
I think we can merge it, if you're ok with that, please merge it. :-) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to test
v2branch and report any bugs. I'll do some testing myself on my own project.You may need to change your
config.neonand make sure parametersgoId,clientIdandclientSecretare strings.amountpassed toPaymentand other API objects must be passed as instance ofMoney\Money,currencyis not used anymore as it is part of the money object itself.closes #38 #40