Configurable possibility to channel on GoPay #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can configure (changeChannel config parameter) a possibility to allow or deny a change of a payment channel on GoPay gate.
|
I like it, but only as property and settter. Could you change it please? |
|
Do you think without setting up from config? |
|
@martinsifra I could be over config, but via setter method. For example like this. if ($config[...]) {
$class->addSetup('setChangeChannel', TRUE);
}A could you merge to one commit please? |
|
Yeah, I see. I'll make commit today. |
|
ping @martinsifra |
|
Sorry, I know. It is on my schedule. |
| @@ -30,6 +30,7 @@ class Extension extends CompilerExtension | |||
| 'gopayId' => NULL, | |||
| 'gopaySecretKey' => NULL, | |||
| 'testMode' => TRUE, | |||
| 'changeChannel' => TRUE, | |||
|
@martinsifra It's great. Could you prepare simple test? And primary, rebase it to 1 commit? |
|
Thanks, I could, but I've never do that. So I'll need more time :-) |
|
@martinsifra It's oukey. I'll do it by my own. |
|
Merged via d545d5d. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can configure (changeChannel config parameter) a possibility to
allow or deny a change of a payment channel on GoPay gate.