Exclude :submit from validation #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Element :submit does not contain validation rules.
|
Hi, thanks for PR. As this script internally uses modified version of original netteForms.js, and this part of code is actually same, you should rather post this PR to https://github.com/nette/forms repository. Then I can "sync" that change to this repo too. It is always better to make such changes to original script. See: https://github.com/nette/forms/blob/master/src/assets/netteForms.js#L228 |
|
Hi @mark-31. Thank you for the PR, I'm closing it now, because current version works good to me. Feel free to open it again or send another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element :submit does not contain validation rules.