Fix LazyTracyLogger containing itself

contributte · May 30, 2019 · b2461ce · b2461ce
1 parent 1d67c9d
commit b2461ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/DI/MonologExtension.php b/src/DI/MonologExtension.php
@@ -148,6 +148,7 @@ public function afterCompile(ClassType $class): void
 		$initialize = $class->getMethod('initialize');
 
 		if (class_exists(Debugger::class) && $config['hook']['fromTracy'] && $builder->hasDefinition('tracy.logger')) {
+			$initialize->addBody('$this->getService("tracy.logger");'); // Create original Tracy\Logger service to prevent psrToTracyLazyAdapter contain itself - workaround for Tracy\ILogger service created statically
 			$initialize->addBody($builder->formatPhp(Debugger::class . '::setLogger(?);', [$this->prefix('@psrToTracyLazyAdapter')]));
 		}
 

diff --git a/tests/Unit/DI/MonologExtensionTest.php b/tests/Unit/DI/MonologExtensionTest.php
@@ -23,7 +23,7 @@ public function testRegistration(): void
 	{
 		$container = $this->createContainer(__DIR__ . '/config.neon');
 
-		// Needed for LoggerHolder
+		// Needed for LoggerHolder and creation of original Tracy\Logger
 		$container->initialize();
 
 		/** @var Logger $default */