Pass true to enableAnnotationMapping()

[MartkCz]

Since symfony/validator 5.2: Not passing true as first argument to "Symfony\Component\Validator\ValidatorBuilder::enableAnnotationMapping" is deprecated. Pass true and call "addDefaultDoctrineAnnotationReader()" if you want to enable annotation mapping with Doctrine Annotations.

[jiripudil]

Hello, thanks! IIRC the enableAnnotationMapping method used to accept an optional instance of annotations Reader. Omitting the argument in service definition meant that Nette DI would autowire a reader if it is registered (e.g. by nettrine/annotations).

I'd like to preserve that behaviour and from what I've found out I think it should be enough to add another setup call:

$validatorBuilder->addSetup('setDoctrineAnnotationReader');

Could you please add that?

[MartkCz]

@jiripudil enableAnnotationMapping can be used without doctrine annotation reader, so I moved it outside of condition

Fix failing test with?

if ($this->getContainerBuilder()->findByType(Reader::class)) {
  $validatorBuilder->addSetup('setDoctrineAnnotationReader');
} else {
  $validatorBuilder->addSetup('addDefaultDoctrineAnnotationReader');
}

[jiripudil]

enableAnnotationMapping can be used without doctrine annotation reader, so I moved it outside of condition

👍

Fix failing test with?

Yes please :) I'd prefer if this code was in beforeCompile though, so that it does not depend on extension registration order.

[jiripudil]

Brilliant, thanks! To fix the failing --prefer-lowest test, could you please bump the symfony/validator dependency to ^5.2? I believe that should be the final bit, then this is ready to merge :)