Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove alert boxes #135

Closed
dbads opened this issue Oct 28, 2018 · 0 comments 路 Fixed by #142 or #151
Closed

Remove alert boxes #135

dbads opened this issue Oct 28, 2018 · 0 comments 路 Fixed by #142 or #151
Assignees
@dbads
Labels
cool its fun easy enhancement New feature or request feature hacktoberfest medium

Comments

@dbads
Copy link
Member

dbads commented Oct 28, 2018 •
edited
Loading

currently there are alert boxes on success/failure of various actions, but these alert boxes aren't good as they block the whole event loop i.e nothing can run asynchronously until alert box is there 馃槃

Try to replace it with snackbars which comes out from bottom or sides and disappears after few seconds.
see this for reference https://material.io/develop/web/components/snackbars/

remove following alert boxes during verification request of pr by student

one for unauthenticated users
one for blank pr_link
one pr submitted
already created pr etc

remove two alert boxes - 30 points 馃槃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbads dbads

Labels
cool its fun easy enhancement New feature or request feature hacktoberfest medium
Projects
None yet
Milestone
No milestone
1 participant
@dbads