Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to terraform 13 #298

Merged
merged 1 commit into from
Sep 22, 2020
Merged

feat: upgrade to terraform 13 #298

merged 1 commit into from
Sep 22, 2020

Conversation

s-irvine
Copy link
Contributor

Fixes #296

jondkent
jondkent reviewed Sep 22, 2020
View reviewed changes
Copy link
Contributor

@jondkent jondkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you outline why you added the versions.tf to each terraform module, seems to be adding maintaince overhead

@s-irvine
Copy link
Contributor Author

The versions.tf is standard terraform syntax now in TF 0.13. Thanks to the new provider source feature all non-hashicorp modules need to have a source defined in the code and it's good practice to also define the source for the hashiscorp modules. The upgrade tool did this automatically so I figured it was worth leaving in.

@jondkent jondkent self-requested a review September 22, 2020 09:44
jondkent
jondkent approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@jondkent jondkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pi-unnerup
pi-unnerup approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@pi-unnerup pi-unnerup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pi-unnerup pi-unnerup merged commit 7ace01d into master Sep 22, 2020
@s-irvine s-irvine deleted the upgrade-to-tf-0.13 branch September 22, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jondkent jondkent jondkent approved these changes

@pi-unnerup pi-unnerup pi-unnerup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to terraform 0.13
3 participants
@s-irvine @jondkent @pi-unnerup