Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table Column Graphics Erorr #858

Open
JonathanGiles opened this issue Jun 30, 2016 · 0 comments
Open

Table Column Graphics Erorr #858

JonathanGiles opened this issue Jun 30, 2016 · 0 comments
Labels
bug Something isn't working Future features TableFilter =
Milestone
Final Release

Comments

@JonathanGiles
Copy link
Collaborator

Original report by Josh (Bitbucket: JoshuaAdams, GitHub: JoshuaAdams).

Hi,

Any pre-existing graphics set on Table Columns get cleared and overwritten with the filter.png defined in the Filterpanel.java upon applying filters to tables. This also occurs on the "Reset Filter" action. See screenshot below for further info...

FilterpngError.png

Suggested repair is to modify the FilterPanel.java to only write the new graphic if there are no pre-existing graphics on tablecolumns or apply this filter graphic in a way that does not interfere with pre-existing graphics.

Kind Regards,

Josh
@JonathanGiles JonathanGiles added major bug Something isn't working Future features labels Dec 29, 2018
@JonathanGiles JonathanGiles added this to the Final Release milestone Dec 29, 2018
abhinayagarwal pushed a commit to abhinayagarwal/controlsfx that referenced this issue Feb 12, 2019
controlsfx#858 Enables custom Category sort for PropertySheet
d5b89ba
abhinayagarwal pushed a commit to abhinayagarwal/controlsfx that referenced this issue Feb 12, 2019
controlsfx#858 Applies changes asked by PR reviewer.
6763765
abhinayagarwal pushed a commit to abhinayagarwal/controlsfx that referenced this issue Feb 12, 2019
@JonathanGiles
Merged in GuillaumeJ/gjourdaincontrolsfx (pull request controlsfx#707)
69c99ef 
controlsfx#858 Enables custom Category sort for PropertySheet

Approved-by: Eugene Ryzhikov <eryzhikov@gmail.com>
Approved-by: Jonathan Giles <jonathan@jonathangiles.net>
@abhinayagarwal abhinayagarwal modified the milestone: Final Release Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Future features TableFilter =
Projects
None yet
Milestone
Final Release
Development

No branches or pull requests
3 participants
@JonathanGiles @abhinayagarwal @Maxoudela