[pull] master from feeluown:master #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
1. fix: if the rpc server port is used, the app crash with no warn 2. fix: app core dump during shutdown (not fully fixed) 3. fix: if user play a media through player.play interface just after app starts, the play range is wrong.
* wip: signal slots in rcfile can be invoked immediately * fuoexec: refactor, can specify connection kwargs such as aioqueue
* Add feeluown.app package * Use asyncio.run as entrypoint
…proper duration/position (#534) * gui: prevent user to drag the slider when there is no media * add unittest and fix CI
* gui: draw close icon when searchbox is visible * setFocus when user click the search button
1. Renderring daily recommended playlists/songs from all providers in homepage. 2. fix #821 Add this option to enable new homepage ```python config.ENABLE_NEW_HOMEPAGE = True ```
pickup from upstream: jaseg/python-mpv@d96eaf7
* library: add protocol SupportsDiscoveryTopList * gui: add toplist page and refactor home
Python 3.12 treats the typo as an error now:
```
=================================== FAILURES ===================================
_____________________________ test_collection_load _____________________________
tmp_path = PosixPath('/tmp/pytest-of-builduser/pytest-0/test_collection_load0')
song = SongModel(meta=<feeluown.library.models.ModelMeta object at 0x7acaf2177c50>, identifier='0', source='fake', state=<Mod...on=600000, children=[], genre='', date='', track='1/1', disc='1/1', pic_url='', media_flags=<MediaFlags.not_sure: 128>)
mocker = <pytest_mock.plugin.MockerFixture object at 0x7acad8c98b60>
def test_collection_load(tmp_path, song, mocker): mock_resolve = mocker.patch('feeluown.collection.resolve',
return_value=song)
path = tmp_path / 'test.fuo'
path.touch()
text = 'fuo://fake/songs/1 # hello - Tom' path.write_text(text)
coll = Collection(str(path))
coll.load()
> mock_resolve.called_once_with(text)
tests/test_collection.py:15:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <MagicMock name='resolve' id='135011639070880'>
name = 'called_once_with'
def __getattr__(self, name):
if name in {'_mock_methods', '_mock_unsafe'}:
raise AttributeError(name)
elif self._mock_methods is not None:
if name not in self._mock_methods or name in _all_magics:
raise AttributeError("Mock object has no attribute %r" % name) elif _is_magic(name):
raise AttributeError(name)
if not self._mock_unsafe and (not self._mock_methods or name not in self._mock_methods):
if name.startswith(('assert', 'assret', 'asert', 'aseert', 'assrt')) or name in _ATTRIB_DENY_LIST:
> raise AttributeError(
f"{name!r} is not a valid assertion. Use a spec "
f"for the mock if {name!r} is meant to be an attribute.") E AttributeError: 'called_once_with' is not a valid assertion. Use a spec for the mock if 'called_once_with' is meant to be an attribute.. Did you mean: 'assert_called_once_with'?
/usr/lib/python3.12/unittest/mock.py:663: AttributeError
```
1. remember search settings (search from which providers) 2. show search performance
- [x] macos-13 ok - [ ] macos-latest still not ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )