Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quit part way through convco commit #113

Closed
rbuckland opened this issue Feb 2, 2023 · 2 comments
Closed

quit part way through convco commit #113

rbuckland opened this issue Feb 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@rbuckland
Copy link

Describe the bug
inside a convco commit after selection of a type, in the field for entering "scope", or the next "description"
you cannot exit (cancel) with ^C or ^D

To Reproduce
Steps to reproduce the behavior:

❯ convco commit
✔ type · feat
? scope () › ^C^C^C^C^C

Expected behavior
The ability to Control-C quit part way through

System (please complete the following information):

  • OS: [ubuntu]
  • Version: [22.04]

Workaround

  1. open new terminal and killall convco ; or
  2. background and kill
❯ convco commit
✔ type · fix
? scope () › ^Z
zsh: suspended  convco commit

✦ ❯ jobs
[1]  + suspended  convco commit

✦ ❯ kill %1
[1]  + terminated  convco commit     
@rbuckland rbuckland added the bug Something isn't working label Feb 2, 2023
@hdevalke
Copy link
Collaborator

hdevalke commented Feb 3, 2023

This is probably related to a change in the dependency dialoguer, or a transient dependency of it, but i can't find a solution right now.

@hdevalke
Copy link
Collaborator

hdevalke commented Feb 3, 2023

It works again when i remove the code introduced here: https://github.com/convco/convco/pull/33/files#diff-bf1e66c5bdfc412eccacf65e5e9734bc1998fdbfc8a06a5f12c5538a66027cceR183

But the cursor is then hidden again, when pressing CTRL-C when selecting the commit type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants