-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore leading comments and empty lines when parsing commit via stdin #114
Comments
as this repository follows conventional commits, comments and extra newlines should be seen as an error, so i think the best way is to add a flag |
The behaviour of git can depend on the |
|
Removes leading and trailing newlines and comments and trailing whitespace from the commit message read from stdin. It also colapses multiple empty lines into one. Refs: #114
I used |
Removes leading and trailing newlines and comments and trailing whitespace from the commit message read from stdin. It also colapses multiple empty lines into one. Refs: #114
Removes leading and trailing newlines and comments and trailing whitespace from the commit message read from stdin. It also colapses multiple empty lines into one. Refs: #114
fixed in #116 |
Is your feature request related to a problem? Please describe.
I just implemented
commit-msg
git hook linting withconvco
: https://github.com/fedimint/fedimint/pull/1573/filesI had to do some extra work, because the commit message can actually be prefixed with newlines and comment lines which git will happily throw away before turning the whole message into a actual commit, but
convco
will complain about.Describe the solution you'd like
Not sure if should be the default behavior altogether, or just when parsing from stdin, or maybe an option, but it would be easier if
convco
could take care of it (ignore leading newlines and comments).The text was updated successfully, but these errors were encountered: