bug: convco commit allows invalid scopes

[cafkafk]

Describe the bug
convco commit allows committing with an invalid scope.

From conventional commits:

4. A scope MAY be provided after a type. A scope MUST consist of a noun describing a section of the codebase surrounded by parenthesis, e.g., fix(parser):

To Reproduce
not relevant

Expected behavior
Convco should not allow spaces in scopes, as that would make the scope not a noun which it MUST be.

System (please complete the following information):
not relevant

Additional context
None I can think of.

[cafkafk]

I suspect it might be this regex that would have to be changed

convco/src/conventional/commits.rs

Line 240 in 81f59f1

scope_regex: "[[:alnum:]]+(?:[-_/][[:alnum:]]+)*".into(),

[hdevalke]

AFK. But this regex does not allow spaces, but maybe needs to have a start ^ and end $ marker.

You could change the regex in the config file. The regex is allowing dashes, slashes and underscores, but not spaces.

[cafkafk]

You could change the regex in the config file. The regex is allowing dashes, slashes and underscores, but not spaces.

Would you want me to PR this or just fix it locally?

[hdevalke]

A PR is nice, I can confirm that it is the issue, but a local fix will be faster, unless you build your own binary from it.

❯ convco check -c <(cat <<< 'scopeRegex: "^[[:alnum:]]+(?:[-_/][[:alnum:]]+)*$"') --from-stdin <<< 'chore(a b): bump deps'; echo $?
could not find repository from '.'; class=Repository (6); code=NotFound (-3)
FAIL  -  scope does not match regex: ^[[:alnum:]]+(?:[-_/][[:alnum:]]+)*$  chore(a b): bump deps
1

~ 
❯ convco check -c <(cat <<< 'scopeRegex: "[[:alnum:]]+(?:[-_/][[:alnum:]]+)*"') --from-stdin <<< 'chore(a b): bump deps'; echo $?
could not find repository from '.'; class=Repository (6); code=NotFound (-3)
0

[hdevalke]

@cafkafk I did create a PR, if the checks are green I will merge this soon. But I won't have the time to create a release this week.

[Hoverbear]

@hdevalke any chance you're planning to cut a release with this fix soon? It would be nice to include this fix in nixpkgs without going to an unstable version.

[hdevalke]

I will release it this evening.

[hdevalke]

@Hoverbear v0.4.3 has been released.

[Hoverbear]

Thanks so much!