-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider warning user if convco commit
is run without any staged files
#146
Comments
At the moment convco commit is indeed building up the commit message, and then executing the git cli. You could use Quick solution could be that we run |
To avoid forgetting to commit unstaged changes, commit will run `git add -N && git add -p` before showing the wizzard. Refs: #146
I made PR #148 to add |
Awesome, can't wait for this to be merged! |
To avoid forgetting to commit unstaged changes, commit will run `git add -N && git add -p` before showing the wizzard. Refs: #146
#151 adds the options --intent-to-add and --patch. This will disable the behavior to automatically do it, but you will be able to use environment variables to override the defaults. |
Is your feature request related to a problem? Please describe.
It's very frustrating when I run
convco commit
, type all the fields, only to find that I didn't stage any files withgit add
.Describe the solution you'd like
I would prefer if
convco commit
printed a warning to the screen, informing me that I haven't staged any files.Describe alternatives you've considered
I've thought that it could be automated, but that would be hard to do in a way that everyone likes, and a lot more work than just a warning that solves the most frustrating part.
Additional context
I don't have any.
The text was updated successfully, but these errors were encountered: