-
Notifications
You must be signed in to change notification settings - Fork 101
fix(cli): Fix cli to work with COMMIT_EDITMSG, custom path or text #92
fix(cli): Fix cli to work with COMMIT_EDITMSG, custom path or text #92
Conversation
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 126 126
=====================================
Hits 126 126 Continue to review full report at Codecov.
|
@kentcdodds or @spirosikmd could you please review this? Thanks! |
Kent is no longer maintaining the project. Is this keeping the original CLI behavior? If not we need to revert the original commit causing the breakage and add a unit test to cover it. Then retry a fix on the original problem. |
@Garbee It is covering all possible behaviors for the CLI as I had described previously with the |
But is this in any way modifying the CLI from the way it worked before? |
No. Still have the same behaviors. Initially the cli only worked validating the commit message from |
does this fix the same problem as #87? |
Yes, It does. And is also covering a problem which I have commented in that
PR.
…On Sun, Jun 25, 2017, 4:26 AM Steve Mao ***@***.***> wrote:
Is it fixing the same problem as #87
<#87>?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAphpNknU9S4Vuxv_5-wrqBCqW8LflNSks5sHguwgaJpZM4OCZlL>
.
|
Sometime ago I had included support to validate a commit message from a text instead of only from files. The validation from a commit message argument stopped working on adding support for GIT GUI tool: d850cf4 This fixing makes CLI support 3 usage ways: 1. Default usage is not passing any argument. It will automatically read from COMMIT_EDITMSG file. 2. Passing a file path argument. For instance GIT GUI stores commit msg @GITGUI_EDITMSG file. 3. Passing commit message as argument. Useful for testing quickly a commit message from CLI.
@Garbee Any plans merging it to master? Or is there any reason for not accepting it? |
I just need to sit down and test it manually. Will do that tomorrow, was working on other issues that were filed earlier today when I went to work on the project. |
Just tested, it looks good to me. Merging now will sit down and chunk the release out by Monday if I can find the time this weekend. Thank you! |
There was an issue with a minor release, so this manual-releases.md change is to release a new minor version. Reference: #92
Addresses a bug introduces with the PR conventional-changelog-archived-repos#92 where the CLI wasn't exiting the process anymore in case of error.
Addresses a bug introduces with the PR conventional-changelog-archived-repos#92 where the CLI wasn't exiting the process anymore in case of error.
Addresses a bug introduces with the PR conventional-changelog-archived-repos#92 where the CLI wasn't exiting the process anymore in case of error
Addresses a bug introduces with the PR #92 where the CLI wasn't exiting the process anymore in case of error
@maxcnunes : In my project, I am passing Scripts section of Package.json file ` cc: @Garbee , @kentcdodds |
@maxcnunes Do you think you'd be able to find the time to take a peek at why this change broke @krishna63's setup? @krishna63 Do you think there is any way you could write a failing unit test for us to work against? |
@krishna63 The problem is that you are specifying in your script to always use the
For me that is the best approach. Is much more explicit of what is going on. @Garbee I can work implementing the fallback by default (first option) or adding support for arguments (second option). Just let me know what you prefer. |
Another approach : pass no argument and let the tool check if there is a |
Sometime ago I had included support to validate a commit message from a text instead of only from files.
The validation from a commit message argument stopped working on adding support for GIT GUI tool: maxcnunes/validate-commit-msg@d850cf4
This fixing makes CLI support 3 usage ways: