feat(container): added @commitlint/config-nx-scopes for nx monorepos #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
reviewed
Feb 14, 2024
gperdomor
force-pushed
the
feature/container-nx-scopes
branch
from
45bf58e
to
77e5ba0
Compare
|
Would you mind rebasing? Then it can be merged |
|
@gperdomor ping? |
gperdomor
force-pushed
the
feature/container-nx-scopes
branch
from
818deee
to
833d680
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
@escapedcat @knocte sorry folks... I didn't see your messages until today... It's rebased now |
|
I assume "container build" will be green once it's merged, right?: Wondering if this check needs to run for PRs |
escapedcat
merged commit aa4df36
into
conventional-changelog:master
7 of 8 checks passed
|
🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds @commitlint/config-nx-scopes package to the container
Motivation and Context
Nx is a very popular tool for monorepos and this change allow the validation of nx scopes using the docker image
Types of changes
Checklist: