Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colons (:) are not allowed in scope name #21

Closed
boroth opened this issue Aug 8, 2014 · 2 comments
Closed

Colons (:) are not allowed in scope name #21

boroth opened this issue Aug 8, 2014 · 2 comments

Comments

@boroth
Copy link

boroth commented Aug 8, 2014

I'd like to update the regex that's used in parseRawCommit() in git.js.

I have a few commits that aren't being added to changelog that aren't being detected because they're formatted as such:

fix(category:subcategory): My subject

I've updated locally for myself, here's the regex that I've added:

var COMMIT_PATTERN = /^(\w*)(\(([\w\:\$\.\-\*]*)\))?\: (.*)$/;

@stevemao
Copy link
Member

Can you send a pull request with tests associated? Thanks

@stevemao
Copy link
Member

Closing for #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants