Switch to ESLint #293
Switch to ESLint #293
Conversation
|
@TheDancingCode thanks! Would it be easier just to use |
|
Yes, but I understood that @hbetts prefers it this way:
|
@stevemao as @TheDancingCode mentioned, I was the one that recommended using ESLint and the As an example, I personally use Visual Studio Code as my primary editor, and the ESLint plugin, which I have installed, has about 5 million downloads, while the Standard plugin has bout 100 thousand. That implies to me a greater likelihood that contributors to this project would be setup with ESLint, and would not need to undertake additional setup steps. It also implies a greater mind share around ESLint that will make it easier to on-board future contributors. |
package.json
Outdated
| "jscs": "^3.0.7", | ||
| "jshint": "^2.9.5", | ||
| "coveralls": "^3.0.0", | ||
| "eslint": "4.18.1", |
There was a problem hiding this comment.
Can these please be updated to use the ^ notation? That way it's implied that we expect our project to work with all future patch and minor releases.
There was a problem hiding this comment.
I will do that. Forgot to undo some recent npm configuration.
| @@ -4,7 +4,7 @@ | |||
| "description": "conventional-changelog angular preset", | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "lint": "jshint *.js --exclude node_modules && jscs *.js", | |||
| "lint": "eslint --fix .", | |||
There was a problem hiding this comment.
I hadn't thought of enabling the auto-fix option (I don't do that in my own personal projects), but I guess I'm fine with it.
| var betterThanBefore = require('better-than-before')(); | ||
| var preparing = betterThanBefore.preparing; | ||
| 'use strict' | ||
| var conventionalChangelogCore = require('conventional-changelog-core') |
There was a problem hiding this comment.
I'm a little disappointed standard doesn't encourage the use of const, or even outright ban the use of var. Oh well. I'll probably switch these all over later.
There was a problem hiding this comment.
If need be, I can add the no-var rule to the config.
There was a problem hiding this comment.
No, let's wait 😄
This change is to just adopt the standard rules for now, and then we can discuss enforcing const across all the conventional-changelog related repositories.
|
|
||
| before(function (done) { | ||
| fs.readFile('templates/commit.hbs', function (err, data) { | ||
| if (err) done(err) |
There was a problem hiding this comment.
Nice! Glad to see this standard already helping to catch uncaught errors.
|
Except for my comment regarding the semantic version range in |
|
Code is now updated according to the requested changes. |
|
@TheDancingCode would you please rebase your pull request? I needed to accept #295, which has led to a conflict in |
|
Rebase done. |
Implements ESLint with
standardcode style.Closes #228.