Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): improve related modules section #427

Merged
merged 3 commits into from
May 5, 2019

Conversation

stevemao
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 25, 2019

Coverage Status

Coverage decreased (-0.2%) to 91.882% when pulling 957df8f on feature/improve-related-modules-docs into 81e03b0 on master.

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some copy edit recommendations (a big one being I think it would be good for us to draw attention to semantic-release which is a huge proponent of this project).

I really like how much this simplifies the docs, good work.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/conventional-changelog-cli/README.md Show resolved Hide resolved
packages/conventional-changelog/README.md Outdated Show resolved Hide resolved
@stevemao
Copy link
Member Author

We haven't done too much on the docs after we put all modules into this monorepo. I think there's a lot of opportunities to clean it up.

## About this Repo

The conventional-changelog repo is managed as a [monorepo](https://github.com/babel/babel/blob/master/doc/design/monorepo.md); it's composed of many npm packages.

The original `conventional-changelog/conventional-changelog` API repo can be
found in [packages/conventional-changelog](https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog).

## Getting started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone lands on this GitHub repository, would they be more interested in how we organize our repository (Discussed in the About this Repo section above), or how to use conventional changelogs?

If the latter, can this section be moved up in the README?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I think we should move it up


It's recommended you use the high level [standard-version](https://github.com/conventional-changelog/standard-version) library, which is a drop-in replacement for npm's `version` command, handling automated version bumping, tagging and CHANGELOG generation.

Alternatively, if you'd like to move towards completely automating your release process as an output from CI/CD, consider using [semantic-release](https://github.com/semantic-release/semantic-release).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot, can we also reference Lerna for mono-repository project developers?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call @hutson, I think this would be another good library to call out; @evocateur perhaps you could share a blurb you'd like us to use?

@bcoe
Copy link
Member

bcoe commented Apr 11, 2019

@stevemao perhaps rebase and we can land this? I agree it would be good to add lerna, but it doesn't need to block this -- @evocateur can add some copy in a bit and we can land it.

@bcoe bcoe merged commit 9c17c36 into master May 5, 2019
@bcoe bcoe deleted the feature/improve-related-modules-docs branch May 5, 2019 03:03
@bcoe
Copy link
Member

bcoe commented May 5, 2019

@stevemao this has been sitting around for a while, so went ahead and landed it 👍 let me know if I messed anything up in the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants