-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(options): add mergeCommitFilter option to cli #595
base: master
Are you sure you want to change the base?
feat(options): add mergeCommitFilter option to cli #595
Conversation
19e44a1
to
e733449
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mediavrog and thank you for contributing. 🎉
I've added some notes on the code.
5d63e42
to
ac1f189
Compare
ac1f189
to
b29dc16
Compare
verified working using the below command on a project using git-flow (and thus tags on merge commits)
|
bd9036b
to
a03d198
Compare
a03d198
to
a7fcf8e
Compare
@tommywo I need some help with the tests. If you could have a look at https://github.com/conventional-changelog/conventional-changelog/pull/595/files#diff-177d48f386b5a5dce18e8dd697f40b1dR304 and point me to what I am doing wrong. Also, I'd ideally want to make the tests for |
@mediavrog I apologize for the slow momentum on this project recently. Could I bother you to resolve the conflicts on this branch? |
I tried doing a quick merge to see if I could get this working but the tests fail for me and I don't understand the internals enough to fix it. If someone has more time than I to look into it, my attempts at cleanup are here |
Based off the discussion on #375 and other issues, I started an implementation to add a new option to either include, exclude or only show merge commits when generating the changelog.
It still needs tests and I need to test the code myself properly, but so far I could already verify that the changelog is complete when just dropping the
merges:false
from thegitRawCommitOpts
inmerge-config.js
.For now, I think the option
merge-commit-filter
should default toexclude
, as this is the current behavior and would not break existing usage.I will try to clean things up later when I have more time, but please also feel free to contribute.