Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for '--skip-unstable' option #656

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

dudekaa
Copy link
Contributor

@dudekaa dudekaa commented Jun 18, 2020

Hi

during usage of your great tool in our team, we came with this little improvement that makes our lives easier.

During our development workflow we often create a few 😄 release candidates in process, which then makes changelog generation little tricky as their number vary.

This new --skip-unstable simply skips all those (alpha, beta, whatever too), so the default --release-count=1 works as expected.

Maybe this will be useful for some other too.

BR
Arnost

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small nits about wording, but this feature looks great to me.

@@ -37,6 +37,8 @@ var cli = meow(`
If 0, the whole changelog will be regenerated and the outfile will be overwritten
Default: 1

--skip-unstable If given, unstable tags will be skipped [ e.g. x.x.x-alpha.1, x.x.x-rc.2 ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might just write this:

 If given, unstable tags will be skipped, e.g., x.x.x-alpha.1, x.x.x-rc.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


Type: `boolean` Default: `false`

If set, unstable release tags will be skipped. EG: x.x.x-rc.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If set, unstable release tags will be skipped, e.g., x.x.x-rc.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and done. also rebased on current master.

dudekaa added a commit to dudekaa/conventional-changelog that referenced this pull request Jun 21, 2020
@bcoe bcoe merged commit 0679d7a into conventional-changelog:master Jun 22, 2020
@bcoe
Copy link
Member

bcoe commented Jun 22, 2020

@dudekaa this looks great to me 👍, thank. you for the contribution.

We just released Friday, so might be a few days before I get this out the door. I check this chat periodically, If I'm moving slow and you need to reach me.

@Wxh16144
Copy link

@dudekaa this looks great to me 👍, thank. you for the contribution.

We just released Friday, so might be a few days before I get this out the door. I check this chat periodically, If I'm moving slow and you need to reach me.

Thank you for your contributions. I am also waiting for the latest release

@Wxh16144
Copy link

This feature has been merged for a month, and the latest version has not been released, I have waited for a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants