Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore gpg lines #685

Merged
merged 2 commits into from
Oct 25, 2020
Merged

fix: ignore gpg lines #685

merged 2 commits into from
Oct 25, 2020

Conversation

bernot-dev
Copy link
Contributor

When a commit is signed with GPG and git config log.showSignature true has been set, it creates additional lines in the raw commit, in this format:

gpg: Signature made Thu Oct 22 12:19:30 2020 EDT
gpg:                using RSA key ABCDEF1234567890
gpg: Good signature from "Author <author@example.com>" [ultimate]

Because these lines occur before the "real" commit begins, the commit is not parsed properly.

This PR ignores these additional lines in the commit message, as they are irrelevant to versioning.

@bcoe bcoe merged commit f8fcbc2 into conventional-changelog:master Oct 25, 2020
@nr-security-github nr-security-github mentioned this pull request Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bernot-dev @bcoe