callback in code usage is not work

[huruji]

I use standard-version in my project, but I found the callback in code usage is not work

my code:

standardVersion({
    }, function(err) {
        console.log('callback')
        if (err) {
            process.chdir(root);
            process.exit()
        }
})

output when standard-version is success

output when standard-version is failed

And I made a breakpoint in my code , but it still not work , I have no idea now. Give me a hand, please

[nexdrew]

The function exported by the main module (index.js) no longer accepts a callback as a 2nd argument - instead it returns a Promise.

This is a breaking change that was introduced between version 4.0.0 and 4.1.0 - meaning the 4.1.0 release should have been 5.0.0. 😞

It also appears the Code usage portion of the README has not been updated to reflect this change either. 😿

So, apologies, it looks like we goofed up here.

In the meantime, try changing your code to something like this instead:

standardVersion()
  .then(_ => console.log('success'))
  .catch(err => {
    process.chdir(root)
    process.exit(1)
  })

[huruji]

Oh, It works. 👍 very thank you!

Returns a Promise is better than using callback, We then need update the docs, can I make a PR to update it? standard-version is a great project, thank you again! 🎉

[stevemao]

@huruji Yes please!

[huruji]

ok, I will @stevemao