Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on windows with JScript compilation errors #50

Closed
Tapppi opened this issue Jun 7, 2016 · 3 comments · Fixed by #53
Closed

Tests fail on windows with JScript compilation errors #50

Tapppi opened this issue Jun 7, 2016 · 3 comments · Fixed by #53
Labels
bug

Comments

@Tapppi
Copy link
Member

Tapppi commented Jun 7, 2016

npm t never even gets to any work on Windows due to a Microsoft JScript compilation error being thrown during each test case.
Tapppi added a commit to Tapppi/standard-version that referenced this issue Jun 7, 2016
@Tapppi
fix(test): explicitly run cli with node to fix tests on windows
3a4245a 
Explicitly run the cli with 'node <index.js path>' to fix running tests on windows.
There seems to be a bug overwriting project package.json and CHANGELOG.md
on windows after failed tests.

Ref Issue conventional-changelog#50
@Tapppi
Copy link
Member Author

Tapppi commented Jun 7, 2016 •
edited

Tests now run, but there seems to be a bug overwriting the project's package.json and CHANGELOG.md with test data after running ALL tests.. If i ctrl-c out of the tests midway through it doesn't happen. Working on it though.

@Tapppi Tapppi added the bug label Jun 8, 2016
@bcoe
Copy link
Member

bcoe commented Jun 8, 2016

@Tapppi interesting, this could be a path bug ... perhaps we're screwing up path.sep or something along these lines?

Tapppi added a commit to Tapppi/standard-version that referenced this issue Jun 8, 2016
@Tapppi
fix(test): explicitly run cli with node to fix tests on windows
0025743 
Explicitly run the cli with 'node <index.js path>' to fix running tests on windows.
There seems to be a bug overwriting project package.json and CHANGELOG.md
on windows after failed tests.

Fixes conventional-changelog#50
@Tapppi
Copy link
Member Author

Tapppi commented Jun 8, 2016

@bcoe Issue #51 for it, I got it fixed already though, I'm creating pull requests for all windows fixes (#49, #51 and this) now.

Tapppi added a commit to Tapppi/standard-version that referenced this issue Jun 8, 2016
@Tapppi
test: explicitly run cli with node to fix tests on windows
725ba1f 
Explicitly run the cli with 'node <index.js path>' to fix running tests on windows.
There seems to be a bug overwriting project package.json and CHANGELOG.md
on windows after failed tests.

Fixes conventional-changelog#50
@Tapppi Tapppi mentioned this issue Jun 8, 2016
Merged
Tapppi added a commit to Tapppi/standard-version that referenced this issue Jun 8, 2016
@Tapppi
test: explicitly run cli with node to fix tests on windows
e76be53 
Explicitly run the cli with 'node <index.js path>' to fix running tests on windows.
There seems to be a bug overwriting project package.json and CHANGELOG.md
on windows after failed tests.

Fixes conventional-changelog#50
Tapppi added a commit to Tapppi/standard-version that referenced this issue Jun 8, 2016
@Tapppi
test: explicitly run cli with node to fix tests on windows
2266ecd 
Explicitly run the cli with 'node <index.js path>' to fix running tests on windows.
There seems to be a bug overwriting project package.json and CHANGELOG.md
on windows after failed tests.

Fixes conventional-changelog#50
Tapppi added a commit to Tapppi/standard-version that referenced this issue Jun 8, 2016
@Tapppi
test: explicitly run cli with node to fix tests on windows
afef731 
Explicitly run the cli with 'node <index.js path>' to fix running tests on windows.

Fixes conventional-changelog#50
nexdrew pushed a commit that referenced this issue Jun 8, 2016
@Tapppi @nexdrew
test: explicitly run cli with node to fix tests on windows (#53)
e160445 
Explicitly run the cli with 'node <index.js path>' to fix running tests on windows.

Fixes #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: explicitly run cli with node to fix tests on windows Tapppi/standard-version
2 participants
@bcoe @Tapppi