Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update search pattern for finding changelog sections #292

Merged
merged 1 commit into from Feb 27, 2019

Conversation

edahlseng
Copy link
Contributor

This pull request updates the search pattern for finding changelog sections to account for section headers that don't have anchors (in addition to section headers that do have anchors).

This change is needed because Conventional Changelog removed anchors from changelog templates. That change has not been included in the conventional-changelog dependency for standard-version yet, but will need to be addressed before it can be. Additionally, manually edited changelogs may not include these anchors, which means that this change will make it easier to adopt standard-version into existing projects.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8d55009 on edahlseng:regex into cbedc52 on conventional-changelog:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8d55009 on edahlseng:regex into cbedc52 on conventional-changelog:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8d55009 on edahlseng:regex into cbedc52 on conventional-changelog:master.

@bcoe
Copy link
Member

bcoe commented Feb 14, 2019

@edahlseng 👋 sorry for the slow response times on code review, this project is in need of more maintainers. Feel free to join slack here:

http://devtoolscommunity.herokuapp.com/

It can be a good way to help coordinate landing patches (and frankly help kick me in the butt, with regards to landing pull requests).

@bcoe
Copy link
Member

bcoe commented Feb 22, 2019

👋 @kimkwanka could I bother you for a code review on this, sounds like you were bit by the bug.

@bcoe bcoe merged commit b684c78 into conventional-changelog:master Feb 27, 2019
@bcoe
Copy link
Member

bcoe commented Feb 28, 2019

@edahlseng if you could take standard-version@5.0.1 for a spin, it should have addressed the issue.

@kimkwanka
Copy link

kimkwanka commented Feb 28, 2019

@bcoe
Thanks a ton Benjamin, and sorry for the late reply, had a super busy week and only got around to check my messages just now.standard-version@5.0.1 works fine on my end.

@sobolevn
Copy link

sobolevn commented Apr 2, 2019

This is still happening for me with standard-version@5.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants