Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K3s setup #4

Merged
merged 6 commits into from
Jun 7, 2023
Merged

K3s setup #4

merged 6 commits into from
Jun 7, 2023

Conversation

rajibhossen
Copy link
Contributor

No description provided.

@vsoch
Copy link
Member

vsoch commented Jun 7, 2023

Nice job @rajibhossen! 🥳 Two quick questions and a suggested change:

  • Is there a reason you want k3s to come up with the entire cluster? I think the use case we were thinking about (at least for the lab) was to have it launched with a job, meaning running in the user's namespace, and it's not running alongside flux but within it (and then multiple users could each control their own cluster). But if you are just doing some testing of how it scales, etc. this should probably be OK.
  • Related to the above - do you want to test rootless mode (or not relevant yet?)
  • And one suggestion / nit is that "flux-selector" should be a variable that matches the name, see here and here for an example of doing that.

@rajibhossen
Copy link
Contributor Author

Thank you!

  1. Yes, I'll integrate/work with that later. I wanted to see k3s deployment using the TF and scripts.
  2. I'm not sure about that yet!
  3. That's a mistake. I was using k3s_setup.sh script from inside of an instance to test. I'll remove that.

@vsoch
Copy link
Member

vsoch commented Jun 7, 2023

Gotcha! Okay one more request - sorry just noticed the structure. I think Abhik had mentioned this, but please make a separate k3s folder within experiments and alongside the autoscale folder that looks like this:

experiments/
   autoscale/
   k3s

And don't do any modifications to the autoscale setup. The reason is because this repository is not a single hard coded research project, but a set of separate, modular experiments (each scoped to a particular purpose) and so the one you are working on (and then will have full ownership over!) is this k3s experiment! And someone can come later that just wants Flux with autoscale, and they still are able to do that without needing to untangle the k3s. Does that make sense?

@rajibhossen
Copy link
Contributor Author

I've decoupled the examples.

Copy link
Member

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto! One quick question, and then we are ready to merrrrge away Merrill! ⚾

examples/k3s/main.tf Outdated Show resolved Hide resolved
@vsoch vsoch merged commit cc12f23 into converged-computing:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants