bug: matches not accounted for with go client #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: we needed to take the intersection of the matches and clusters known to the user config as the final set to return. Currently we are just providing all the clusters in the user config, regardless of match. Solution: create a function to retrieve the token for a named cluster, which only returns the token if it is known. This is akin to taking an intersection between the matches and clusters known. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: we needed to take the intersection of the matches and clusters known to the user config as
the final set to return. Currently we are just providing all the clusters in the user config,
regardless of match.
Solution: create a function to retrieve the token for a named cluster, which only returns the token if it is known. This is akin to taking an intersection between the matches and clusters known.