Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-creation of collections should be configurable #139

Closed
mmacfadden opened this issue Jun 20, 2020 · 1 comment
Closed

Auto-creation of collections should be configurable #139

mmacfadden opened this issue Jun 20, 2020 · 1 comment
Assignees
Labels
admin-console Issues related to the Admin Console breaking The resolution creates a breaking API change enhancement New feature or request server Issues related to the server
Milestone

Comments

@mmacfadden
Copy link
Contributor

mmacfadden commented Jun 20, 2020

Versions

  • Convergence Version: 1.0.0-rc.6

Description
At the moment, if you create a model in a collection that does not exist, the collection is auto created. It would be good if this behavior could be disabled to allow models to only be created in existing collections. This would prevent accidentally creating a model in the wrong collection due to a typo or programming error.

This would be a per-domain configuration and need to be added to the settings for the domain.

An important note here is that this is the only way to effectively control model creation in the system. With the current behavior there is nothing stopping any user in the system from creating a model in a collection that doesn't exist. For existing collection, administrators can control who can create models in which collections. But non-existent collections would be created automatically with generous world permissions allowing anyone to create a model in a new collection.

Breaking Change

This is a somewhat breaking change. If upgrading your server this feature will be enabled by default on existing domains. Additionally, the default domain automatically created will have the feature enabled. So from that perspective it is not breaking. However, any newly created domains will have this feature disabled, which represents a behavior change in the system.

@mmacfadden mmacfadden added enhancement New feature or request admin-console Issues related to the Admin Console server Issues related to the server labels Jun 20, 2020
@mmacfadden mmacfadden added this to the Backlog milestone Jun 20, 2020
@mmacfadden mmacfadden modified the milestones: Backlog, 1.0.0-rc.9 May 22, 2021
@mmacfadden
Copy link
Contributor Author

Here is a mock up of the new option in the admin console.

image

mmacfadden added a commit to convergencelabs/convergence-admin-console that referenced this issue Jun 1, 2021
@mmacfadden mmacfadden self-assigned this Jun 1, 2021
@mmacfadden mmacfadden added the breaking The resolution creates a breaking API change label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin-console Issues related to the Admin Console breaking The resolution creates a breaking API change enhancement New feature or request server Issues related to the server
Projects
None yet
Development

No branches or pull requests

1 participant