Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to change a domain's id #214

Closed
mmacfadden opened this issue Jun 5, 2021 · 2 comments
Closed

Ability to change a domain's id #214

mmacfadden opened this issue Jun 5, 2021 · 2 comments
Assignees
@mmacfadden
Labels
admin-console Issues related to the Admin Console enhancement New feature or request server Issues related to the server
Milestone
1.0.0-rc.9

Comments

@mmacfadden
Copy link
Contributor

Versions

  • Convergence Version: 1.0.0-rc.8

Description
It would be ideal if the id of a domain could be changed after it is created. This will require the domain to be offline when the id change happens. This creates a dependency on #205.

Is there a workaround in the absence of this feature?
No.
@mmacfadden mmacfadden added enhancement New feature or request admin-console Issues related to the Admin Console server Issues related to the server labels Jun 5, 2021
@mmacfadden mmacfadden added this to the 1.0.0-rc.9 milestone Jun 5, 2021
@mmacfadden mmacfadden self-assigned this Jun 5, 2021
@mmacfadden
Copy link
Contributor Author

This feature will be added to the "Dangerous" settings in the domain.

image

mmacfadden added a commit to convergencelabs/convergence-admin-console that referenced this issue Jun 5, 2021
@mmacfadden
Added the ability to change a domain's id
d94bc51 
Admin Console portion of convergencelabs/convergence-project#214
mmacfadden added a commit to convergencelabs/convergence-server that referenced this issue Jun 5, 2021
@mmacfadden
Partial server side implementation of changing the domain id
22ccdf2 
Server side portion of convergencelabs/convergence-project#214
@mmacfadden
Copy link
Contributor Author

mmacfadden commented Jun 5, 2021 •
edited

Made good progress here. There are two items left:

  • The UI doesn't completely handle when the domain is renamed, hanging on to the old id for the active domain.
  • The server should reject the command if the domain isn't actually in an offline state.

@mmacfadden mmacfadden changed the title Ability to rename a domain Ability to change a domain's id Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmacfadden mmacfadden

Labels
admin-console Issues related to the Admin Console enhancement New feature or request server Issues related to the server
Projects
None yet
Milestone
1.0.0-rc.9
Development

No branches or pull requests
1 participant
@mmacfadden