Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModelPermissionManager.setAllUserPermissions doesn't set permissions (regression) #238

Closed
mmacfadden opened this issue Jul 11, 2021 · 0 comments
Closed

ModelPermissionManager.setAllUserPermissions doesn't set permissions (regression) #238

mmacfadden opened this issue Jul 11, 2021 · 0 comments
Assignees
@mmacfadden
Labels
bug Something isn't working client Issues related to the client
Milestone
1.0.0-rc.10

Comments

@mmacfadden
Copy link
Contributor

Versions

  • Convergence Version: 1.0.0.rc.9

Describe the Bug
A regression was introduced in 1.0.0-rc.9 that prevents the ModelPermissionManager.setAllUserPermissions method from working. The usernames are encoded improperly in the protocol message conversation.
@mmacfadden mmacfadden added bug Something isn't working client Issues related to the client labels Jul 11, 2021
@mmacfadden mmacfadden added this to the 1.0.0-rc.10 milestone Jul 11, 2021
@mmacfadden mmacfadden self-assigned this Jul 11, 2021
mmacfadden added a commit to convergencelabs/convergence-client-javascript that referenced this issue Jul 11, 2021
@mmacfadden
Fixed userId serialization in ModelPermissionsManager
2653c3b 
Fixes convergencelabs/convergence-project#238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmacfadden mmacfadden

Labels
bug Something isn't working client Issues related to the client
Projects
None yet
Milestone
1.0.0-rc.10
Development

No branches or pull requests
1 participant
@mmacfadden