Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Activity protocol to use a resourceId #65

Closed
mmacfadden opened this issue Jan 11, 2020 · 0 comments
Closed

Update Activity protocol to use a resourceId #65

mmacfadden opened this issue Jan 11, 2020 · 0 comments
Assignees
@mmacfadden
Labels
breaking The resolution creates a breaking API change client Issues related to the client enhancement New feature or request server Issues related to the server
Milestone
1.0.0-rc.9

Comments

@mmacfadden
Copy link
Contributor

mmacfadden commented Jan 11, 2020 •
edited

Activities currently use a string identifier when sending messages. This is somewhat inefficient. In the model subsystem we map user defined string identifiers to int32 resource ids, which are more compact. We should do the same thing in activities.

Breaking Change

This will be a non-backwards compatible change in the protocol, but has not API changes.
@mmacfadden mmacfadden added enhancement New feature or request breaking The resolution creates a breaking API change labels Jan 11, 2020
@mmacfadden mmacfadden added this to the 1.0.0-rc.6 milestone Jan 11, 2020
mmacfadden added a commit to convergencelabs/convergence-client-javascript that referenced this issue Jan 11, 2020
@mmacfadden
Refactored model resourceId management
42974e1 
Work in progress on convergencelabs/convergence-project#65
@mmacfadden mmacfadden modified the milestones: 1.0.0-rc.6, 1.0.0-rc.7 Apr 1, 2020
@mmacfadden mmacfadden modified the milestones: 1.0.0-rc.7, 1.0.0-rc.8 May 23, 2020
@mmacfadden mmacfadden modified the milestones: 1.0.0-rc.8, 1.0.0-rc.9 Aug 1, 2020
@mmacfadden mmacfadden changed the title Add resourceId concept to the activity Update Activity protocol to use a resourceId Jun 8, 2021
@mmacfadden mmacfadden self-assigned this Jun 8, 2021
@mmacfadden mmacfadden added client Issues related to the client server Issues related to the server labels Jun 8, 2021
mmacfadden added a commit to convergencelabs/convergence-proto that referenced this issue Jun 8, 2021
@mmacfadden
Updated activity messages with a resource id
2136344 
Partial implementation of convergencelabs/convergence-project#65
mmacfadden added a commit to convergencelabs/convergence-server that referenced this issue Jun 8, 2021
@mmacfadden
Updates the activity system to use resource ids.
bc1718a 
Server side portion of convergencelabs/convergence-project#65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmacfadden mmacfadden

Labels
breaking The resolution creates a breaking API change client Issues related to the client enhancement New feature or request server Issues related to the server
Projects
None yet
Milestone
1.0.0-rc.9
Development

No branches or pull requests
1 participant
@mmacfadden