Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation keys doesn't work anymore into chat input message #2754

Closed
SilverYoCha opened this issue Dec 14, 2021 · 2 comments
Closed

Navigation keys doesn't work anymore into chat input message #2754

SilverYoCha opened this issue Dec 14, 2021 · 2 comments

Comments

@SilverYoCha
Copy link
Contributor

SilverYoCha commented Dec 14, 2021

Describe the bug
Sometimes, but often after trying to edit a previous message, navigation keys into input message do not work anymore.
It is no more possible to use left key, for example, to position the cursor one letter before.

To Reproduce
It is been a while that I try to identify a reproductible case, but without success.
Has anyone ever got this behavior?

Expected behavior
Navigation keys always usable.

Environment (please complete the following information):

  • Desktop
  • Browser all common WEB browsers
  • Since Converse.js v7 (I don't know for previous versions)

Additional context
ConverseJS is used in overlayed mode.

Initialization options
 converse.initialize({
          'view_mode' : 'overlayed',
          'i18n' : 'a language',
          'assets_path' : '/myserver/chat/converse/',
          'sounds_path' : '/myserver/chat/converse/',
          'play_sounds' : false,
          'bosh_service_url' : 'bosh url',
          'allow_logout' : false,
          'auto_login' : true,
          'auto_reconnect' : true,
          'jid' : 'a jid',
          'default_domain' : 'a domain',
          'domain_placeholder' : 'a domain',
          'password' : 'a password',
          'autocomplete_add_contact' : false,
          'notification_icon' : 'aLogo.png',
          'muc_domain' : 'conference.a.domain',
          'locked_muc_domain' : 'hidden',
          'muc_disable_slash_commands' : true,
          'locked_muc_nickname' : true,
          'nickname' : 'a nickname',
          'auto_register_muc_nickname' : true,
          'notify_all_room_messages' : true,
          'auto_join_on_invite' : false,
          'roster_groups' : false,
          'allow_adhoc_commands' : false,
          'allow_contact_removal' : false,
          'allow_contact_requests' : false,
          'allow_registration' : false,
          'show_controlbox_by_default' : false,
          'discover_connection_methods' : false
        });
@deleolajide
Copy link
Member

Has anyone ever got this behavior?

I can confirm it. It is difficult to reproduce, but I get a fairly consistent hit after using an emoji. I am yet to confirm if it happens when no external plugins are activated.

@Echolon Echolon changed the title Sometimes, navigation keys doesn't work anymore into chat input message Navigation keys doesn't work anymore into chat input message Dec 18, 2021
@SilverYoCha
Copy link
Contributor Author

I finally found a reproductible case.

  • write and send a message (it is just at least to have one)
  • open emojis drop down
  • select one by using navigation keys
  • close emojis drop down by using escape key
  • try to modify previous message by using navigational keys

SilverYoCha added a commit to SilverYoCha/converse.js that referenced this issue Mar 8, 2022
@jcbrand jcbrand closed this as completed in 7409668 Mar 9, 2022
jcbrand added a commit that referenced this issue Mar 9, 2022
Trigger an `emojiSelected` event instead of manually calling `insertIntoTextArea` on the `converse-message-form` a component.
This loosens the coupling between the emoji picker and `converse-message-form`.

Call `disableArrowNavigation` when the emoji-picker is disconnected from
the DOM or when escape is pressed. See #2754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants