Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge color not responsive to dark theme. #3246

Closed
Zash opened this issue Jul 30, 2023 · 2 comments
Closed

Badge color not responsive to dark theme. #3246

Zash opened this issue Jul 30, 2023 · 2 comments

Comments

@Zash
Copy link
Contributor

Zash commented Jul 30, 2023

The class used for Hats sets text color to white:

.badge-secondary {
color: white;

This leads to poor contrast when combined with a dark theme:
image

I imagine the solution is to use a variable, but which?

@jcbrand
Copy link
Member

jcbrand commented Jul 31, 2023

Probably just var(--background)

@jcbrand jcbrand closed this as completed in 808efd3 Aug 1, 2023
@Zash
Copy link
Contributor Author

Zash commented Aug 1, 2023

Thanks!

jcbrand added a commit that referenced this issue Aug 31, 2023
jcbrand added a commit that referenced this issue Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants