Some offline users have a visible empty <dd> in the roster

[floriancargoet]

With hide_offline_users: true, there's a display bug: some <dd> are empty but not hidden.

See screenshots :

Collapsing and expanding a group "solves" the display bug because of filtering.

[floriancargoet]

I think the bug was identified, I found this :

 show: function () {
  // FIXME: There's a bug here, if show_only_online_users is true
  // Possible solution, get the group, call _.each and check
  // showInRoster
  this.$el.nextUntil('dt').addBack().show();
},

[floriancargoet]

An easy solution would be to filter the nextUntil and only select online contacts:

this.$el.nextUntil('dt', '.online').addBack().show();

But the online class is still there after a contact has gone offline, so maybe that needs fixing too.

[floriancargoet]

I've realised that it's not exactly the same bug. The comment is about the show_only_online_users option, not hide_offline_users.

[floriancargoet]

OK, I think I've worked out something :

            show: function () {
                this.$el.show();
                _.each(this.getAll(), function (contactView) {
                    if (contactView.model.showInRoster()) {
                        contactView.$el.show();
                    }
                });
            },

PR coming.