Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower install converse fails #379

Closed
scags9876 opened this issue Apr 25, 2015 · 4 comments
Closed

bower install converse fails #379

scags9876 opened this issue Apr 25, 2015 · 4 comments

Comments

@scags9876
Copy link

When I try to install converse.js via bower, I get the error below, indicating that the version of crypto-js specified as a dependency does not exist:

bower install converse.js
...
bower crypto-js-evanvosberg#3.1.2-5 ENORESTARGET No tag found that was able to satisfy 3.1.2-5

Additional error details:
Available versions: 3.1.4, 3.1.3

@jcbrand
Copy link
Member

jcbrand commented Apr 25, 2015

Yes, an older release of crypto-js is no longer available via bower. I think it's because @evanvosberg changed the naming convention of tags/releases. Older releases where prefixed with "release-" and newer releases aren't. See here: https://github.com/evanvosberg/crypto-js/releases

Would be best if bower could be a bit more clever here and also pick up older releases, it might be worth making a bug report on the bower page.

I've already updated bower.json in the master branch of converse.js but this won't fix the problem for older releases of converse.js. I'll make a new release of converse.js soon, and from that version onward at least this problem should be fixed.

@jcbrand jcbrand closed this as completed Apr 25, 2015
@scags9876
Copy link
Author

Great! Thanks!
On Apr 25, 2015 1:04 PM, "JC Brand" notifications@github.com wrote:

Yes, an older release of crypto-js is no longer available via bower. I
think it's because @evanvosberg https://github.com/evanvosberg changed
the naming convention of tags/releases. Older releases where prefixed with
"release-" and newer releases aren't. See here:
https://github.com/evanvosberg/crypto-js/releases

Would be best if bower could be a bit more clever here and also pick up
older releases, it might be worth making a bug report on the bower page.

I've already updated bower.json in the master branch of converse.js but
this won't fix the problem for older releases of converse.js. I'll make a
new release of converse.js soon, and from that version onwards at least
this problem should be fixed.


Reply to this email directly or view it on GitHub
#379 (comment).

@evanvosberg
Copy link

Just to make it more understandable, all version prior 3.1.3 are not designed to use with bower.

Why?

  • all prior versions don't have a bower.json file
  • bower doesn't prefer pre-release versions like npm
    • npm: want 3.1.2 get 3.1.2-5
    • bower: want 3.1.2 get 3.1.2

For those reasons I renamed all prior versions to make them not available as semver tags, the releases before are totally different and could confuse people.

So 3.1.3 is the first released design to use with bower and npm, the current stable version is 3.1.4 and 3.1.5 with small fixed is in dev ...

@jcbrand
Copy link
Member

jcbrand commented Apr 26, 2015

@evanvosberg, thanks for responding.

It's unfortunate that you renamed those releases because now previous tags/releases of converse.js (and I assume other projects as well) cannot be built any more.

I can fix this in the master branch of converse.js, but older tags are supposed to be immutable so it can't easily be fixed there.

We've been using crypto-js via bower for quite a long time now and the fact that those previous releases weren't consciously designed to work with bower didn't pose a problem to us at all.

In the Python community, it's taken for granted that old releases are never changed or removed from Pypi (the package store). I wish the same could be expected from Javascript/bower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants