Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible fix for issue #1185 #1249

Closed
wants to merge 3 commits into from
Closed

Conversation

kagesys
Copy link

@kagesys kagesys commented Oct 17, 2018

Thanks for making a pull request to converse.js!

Before submitting your request, please make sure the following conditions are met:

  • Add a changelog entry for your change in CHANGES.md
  • When adding a configuration variable, please make sure to
    document it in docs/source/configuration.rst
  • Please add a test for your change. Tests can be run in the commandline
    with make check or you can run them in the browser by running make serve
    and then opening http://localhost:8000/tests.html.

@jcbrand
Copy link
Member

jcbrand commented Oct 17, 2018

Hi @alanrevans, your commit d03884f looks indeed like it fixes #1185. Thanks!

I looked at the logs provided in that issue and the roster push IQ stanza includes a from attribute. My own XMPP server doesn't, which is why this bug eluded me.

I've manually merged that commit.

Did you also intend to include the other two commits in this pull request? If so, can you please explain the rationale for each?

@jcbrand jcbrand closed this Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants