make it configurable whether to respect autojoin #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaosKid42
force-pushed
the
make_autojoin_configurable
branch
2 times, most recently
from
1247114
to
2dccf2e
Compare
jcbrand
reviewed
Mar 8, 2019
CHANGES.md
Outdated
| @@ -17,6 +17,7 @@ | |||
| - #1437: List of groupchats in modal doesn't scroll | |||
| - #1457: Wrong tooltip shown for "unbookmark" icon | |||
| - #1479: Allow file upload by drag & drop also in MUCs | |||
| - #1487: New config option `muc_respect_autojoin` | |||
There was a problem hiding this comment.
You can now already set it to the URL that it will be when it's released. Take a look at the URLs of other config options. You generally just have to replace underscores with dashes at the end of the URL.
There was a problem hiding this comment.
Nice. Changed the PR accordingly.
ChaosKid42
force-pushed
the
make_autojoin_configurable
branch
from
2dccf2e
to
ddb4320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to turn off converse.js' behaviour of autojoining MUCs bases on their bookmarks. This PR adds a new config option
muc_respect_autojoinwhich allows this.