Fix the known bug where a state notification reopens a chat box #357
Conversation
|
Thanks a lot for your pull requests. I like the fact that you've come up with a simple solution to solve this particular issue. However there is a bigger architectural issue that I want to resolve which should then also fix this bug. At the moment, as soon as a chat box is created, it's also opened and appears to the user. I want to change the code so that creating a chat box doesn't automatically open it as well. This should resolve certain issues with the API as well. I'll first try that and see how it goes before deciding whether it then still makes sense to merge this particular pull request or not. |
|
OK, after doing some refactoring as explained above, I realize that your change is still perfectly valid and compatible. |
…eopen-box Fix the known bug where a state notification reopens a chat box
This caused a bug whereby a chat box would open only on chat state notifications. Also refactored the chats.open and chats.get methods so that they now reuse the same map function and so that chats.get can now return any chat box and not just already open ones. Updated the tests to properly test this and updated the docs.
|
Thank you for merging these PRs so quickly. |
When a state notification is received, a chat box is opened. If the notification is the result of the other person closing the chat box, it's annoying. User 1 closes a box, user 2 sees a box auto opening. User 2 closes the new box, user 1 sees a box auto opening. This has no end.
It's a known bug since there's a FIXME comment in the code.
I propose this fix: only open a chat box when the message has a body (i.e. a real message).